Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: username and password provided in config.yaml is not working #864

Merged
merged 6 commits into from
Nov 6, 2022

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Oct 26, 2022

Changes

#856

Fixes

call SetAdminCredentials() before going further.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber 856
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #864 (a2a7c5a) into staging (9c638d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #864   +/-   ##
========================================
  Coverage    26.29%   26.29%           
========================================
  Files           77       77           
  Lines         7879     7879           
========================================
  Hits          2072     2072           
  Misses        5535     5535           
  Partials       272      272           
Flag Coverage 螖
Unit-Tests 26.29% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix-creds
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber 856
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

code/go/0chain.net/core/common/admin.go Outdated Show resolved Hide resolved
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber 856
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants