Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make admin api public for debugging purpose #877

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Make admin api public for debugging purpose #877

merged 2 commits into from
Nov 22, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Nov 16, 2022

Changes

This PR will make admin api public. This is only for the debugging purpose. Later on it should be undone.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

boddumanohar
boddumanohar approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@boddumanohar boddumanohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kishan-Dhakan Kishan-Dhakan merged commit a9f861b into staging Nov 22, 2022
@Kishan-Dhakan Kishan-Dhakan deleted the allow/admin-api branch November 22, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boddumanohar boddumanohar boddumanohar approved these changes

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lpoli @boddumanohar @Kishan-Dhakan