Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playlist): fixed loadPlaylist for generic media file #890

Merged
merged 7 commits into from
Dec 12, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Dec 12, 2022

Changes

Fixes

  • fixed play shared generic media file

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #890 (7c6b2cc) into staging (ceae386) will decrease coverage by 0.02%.
The diff coverage is 4.34%.

@@             Coverage Diff             @@
##           staging     #890      +/-   ##
===========================================
- Coverage    26.39%   26.36%   -0.03%     
===========================================
  Files           77       77              
  Lines         7889     7897       +8     
===========================================
  Hits          2082     2082              
- Misses        5535     5543       +8     
  Partials       272      272              
Flag Coverage 螖
Unit-Tests 26.36% <4.34%> (-0.03%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...de/go/0chain.net/blobbercore/reference/playlist.go 0.00% <0.00%> (酶)
...0chain.net/blobbercore/handler/handler_playlist.go 25.75% <7.14%> (-3.06%) 猬囷笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cnlangzi cnlangzi merged commit f3ac0e1 into staging Dec 12, 2022
@cnlangzi cnlangzi deleted the fix/play_shared_meida branch December 12, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants