Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

476 toggle permission to uploaddelete update move copy and rename #891

Conversation

devyetii
Copy link
Collaborator

Changes

  • Changes regarding allocation to support NFT by adding file_options to guard object operations on this allocation

Fixes

#476

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@devyetii
Copy link
Collaborator Author

devyetii commented Dec 14, 2022

requires 0chain/gosdk#687 to be merged

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain staging
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Merging #891 (733b167) into staging (2305c9a) will decrease coverage by 0.07%.
The diff coverage is 2.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #891      +/-   ##
===========================================
- Coverage    26.46%   26.40%   -0.07%     
===========================================
  Files           77       77              
  Lines         7866     7886      +20     
===========================================
  Hits          2082     2082              
- Misses        5512     5530      +18     
- Partials       272      274       +2     
Flag Coverage Δ
Unit-Tests 26.40% <2.77%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <0.00%> (ø)
...e/go/0chain.net/blobbercore/allocation/protocol.go 0.00% <0.00%> (ø)
...de/go/0chain.net/blobbercore/allocation/workers.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/allocation/zcn.go 0.00% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 31.08% <0.00%> (-0.22%) ⬇️
.../0chain.net/blobbercore/handler/storage_handler.go 22.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk staging
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@devyetii devyetii mentioned this pull request Feb 1, 2023
3 tasks
…and-rename' of github.com:0chain/blobber into 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk NOT OVERRIDDEN
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk NOT OVERRIDDEN
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toggle permission to upload,delete, update, move, copy and rename.
4 participants