Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(writepreredeem): fixed WritePools gorm issues #914

Merged
merged 8 commits into from
Jan 20, 2023

Conversation

cnlangzi
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #914 (e8d7599) into staging (670a2a3) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging     #914      +/-   ##
===========================================
+ Coverage    26.41%   26.43%   +0.02%     
===========================================
  Files           77       77              
  Lines         7883     7875       -8     
===========================================
  Hits          2082     2082              
+ Misses        5529     5521       -8     
  Partials       272      272              
Flag Coverage 螖
Unit-Tests 26.43% <0.00%> (+0.02%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <0.00%> (酶)
...et/blobbercore/handler/object_operation_handler.go 31.29% <0.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cnlangzi cnlangzi marked this pull request as draft January 17, 2023 11:32
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/get_write_pool_gorm_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@cnlangzi cnlangzi changed the title fix(writepreredeem): fixed sum issue in gorm fix(writepreredeem): fixed WritePool issues Jan 19, 2023
@cnlangzi cnlangzi changed the title fix(writepreredeem): fixed WritePool issues fix(writepreredeem): fixed WritePools issues Jan 19, 2023
@cnlangzi cnlangzi changed the title fix(writepreredeem): fixed WritePools issues fix(writepreredeem): fixed WritePools gorm issues Jan 19, 2023
@cnlangzi cnlangzi marked this pull request as ready for review January 19, 2023 11:23
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 0d505a4 into staging Jan 20, 2023
@cnlangzi cnlangzi deleted the fix/get_write_pool_gorm_issue branch January 27, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WritePools gorm issues
4 participants