Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

marketing fields fix #926

Merged
merged 4 commits into from
Jan 29, 2023
Merged

marketing fields fix #926

merged 4 commits into from
Jan 29, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Jan 26, 2023

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #926 (f7169a1) into staging (d5d3fb8) will increase coverage by 0.09%.
The diff coverage is 0.00%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #926      +/-   ##
===========================================
+ Coverage    26.37%   26.46%   +0.09%     
===========================================
  Files           77       77              
  Lines         7875     7867       -8     
===========================================
+ Hits          2077     2082       +5     
+ Misses        5526     5513      -13     
  Partials       272      272              
Flag Coverage 螖
Unit-Tests 26.46% <0.00%> (+0.09%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <0.00%> (酶)
code/go/0chain.net/core/lock/lock.go 100.00% <0.00%> (+12.50%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will not work. the implementation will cause issue. please see https://github.com/0chain/blobber/pull/914/files for detail

Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit bc43ec4 into staging Jan 29, 2023
@cnlangzi cnlangzi deleted the fix/sum-balance branch January 29, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants