Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update writemarker lock function #931

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Jan 30, 2023

Changes

  • Allow client to refresh existing lock

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Merging #931 (0299d8c) into staging (a264988) will decrease coverage by 0.10%.
The diff coverage is 75.00%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #931      +/-   ##
===========================================
- Coverage    26.63%   26.53%   -0.10%     
===========================================
  Files           76       76              
  Lines         7648     7638      -10     
===========================================
- Hits          2037     2027      -10     
  Misses        5345     5345              
  Partials       266      266              
Flag Coverage 螖
Unit-Tests 26.53% <75.00%> (-0.10%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ode/go/0chain.net/blobbercore/writemarker/mutex.go 57.97% <75.00%> (-5.33%) 猬囷笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/concurrent-operation-issue
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/concurrent-operation-issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/concurrent-operation-issue
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/concurrent-operation-issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg
Copy link
Member

Mark system tests as pass as changes are not related to the errors.

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/concurrent-operation-issue
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg peterlimg merged commit ccd9e2f into staging Feb 18, 2023
@peterlimg peterlimg deleted the fix/concurrent-operation-issue branch February 18, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants