Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove collaborator #944

Merged
merged 4 commits into from
Feb 15, 2023
Merged

remove collaborator #944

merged 4 commits into from
Feb 15, 2023

Conversation

boddumanohar
Copy link
Contributor

Changes

  • remove all collaborator related APIs from blobbers

Fixes 0chain/0chain#2010

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg
Copy link
Member

Please fix the conflicts

@codecov-commenter
Copy link

Codecov Report

Merging #944 (d2478ef) into staging (9047518) will increase coverage by 0.16%.
The diff coverage is 14.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #944      +/-   ##
===========================================
+ Coverage    26.40%   26.56%   +0.16%     
===========================================
  Files           77       76       -1     
  Lines         7886     7648     -238     
===========================================
- Hits          2082     2032      -50     
+ Misses        5530     5350     -180     
+ Partials       274      266       -8     
Flag Coverage Δ
Unit-Tests 26.56% <14.28%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/blobbercore/handler/context.go 35.91% <ø> (+0.98%) ⬆️
...ain.net/blobbercore/handler/file_command_update.go 0.00% <0.00%> (ø)
.../go/0chain.net/blobbercore/handler/grpc_handler.go 12.37% <ø> (+2.53%) ⬆️
code/go/0chain.net/blobbercore/handler/handler.go 62.71% <ø> (-0.99%) ⬇️
...o/0chain.net/blobbercore/handler/handler_common.go 18.07% <ø> (-1.03%) ⬇️
.../0chain.net/blobbercore/handler/storage_handler.go 23.28% <0.00%> (+0.52%) ⬆️
...et/blobbercore/handler/object_operation_handler.go 31.53% <50.00%> (+0.44%) ⬆️
code/go/0chain.net/core/lock/lock.go 87.50% <0.00%> (-12.50%) ⬇️
...ain.net/blobbercore/handler/file_command_upload.go 40.66% <0.00%> (-1.34%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber remove-collaborator
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg peterlimg merged commit b064087 into staging Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup collaborator feature
4 participants