Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed variable hiding #947

Merged
merged 2 commits into from
Feb 17, 2023
Merged

fixed variable hiding #947

merged 2 commits into from
Feb 17, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Feb 15, 2023

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/variable-hiding
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@codecov-commenter
Copy link

Codecov Report

Merging #947 (9e9c9c5) into staging (44922e6) will not change coverage.
The diff coverage is n/a.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging     #947   +/-   ##
========================================
  Coverage    26.63%   26.63%           
========================================
  Files           76       76           
  Lines         7648     7648           
========================================
  Hits          2037     2037           
  Misses        5345     5345           
  Partials       266      266           
Flag Coverage 螖
Unit-Tests 26.63% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterlimg peterlimg merged commit a264988 into staging Feb 17, 2023
@peterlimg peterlimg deleted the fix/variable-hiding branch February 17, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants