Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 978 #988

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Revert PR 978 #988

merged 1 commit into from
Mar 8, 2023

Conversation

Kishan-Dhakan
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #988 (731c0e8) into staging (2f30e10) will not change coverage.
The diff coverage is n/a.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging     #988   +/-   ##
========================================
  Coverage    25.98%   25.98%           
========================================
  Files           76       76           
  Lines         7806     7806           
========================================
  Hits          2028     2028           
  Misses        5506     5506           
  Partials       272      272           
Flag Coverage 螖
Unit-Tests 25.98% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk expose-few-funcs
zboxcli staging
zwalletcli staging
0chain staging
blobber revert/978
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/list-all
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber revert/978
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@lpoli
Copy link
Contributor

lpoli commented Mar 8, 2023

I don't see point in merging this PR.
Lets not do it.

@lpoli lpoli closed this Mar 8, 2023
@lpoli lpoli reopened this Mar 8, 2023
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber revert/978
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit bacfa51 into staging Mar 8, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the revert/978 branch March 8, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants