Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for lock expiry #992

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Check for lock expiry #992

merged 4 commits into from
Mar 13, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Mar 9, 2023

Fixes

Expire lock if some lock acquiring process does not release lock.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #992 (6b95dc7) into staging (f3daf59) will decrease coverage by 0.07%.
The diff coverage is 7.69%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #992      +/-   ##
===========================================
- Coverage    26.13%   26.06%   -0.07%     
===========================================
  Files           76       76              
  Lines         7760     7769       +9     
===========================================
- Hits          2028     2025       -3     
- Misses        5460     5471      +11     
- Partials       272      273       +1     
Flag Coverage 螖
Unit-Tests 26.06% <7.69%> (-0.07%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ode/go/0chain.net/blobbercore/writemarker/mutex.go 47.43% <7.69%> (-10.54%) 猬囷笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg peterlimg merged commit 13324a4 into staging Mar 13, 2023
@peterlimg peterlimg deleted the fix/lock-expiry branch March 13, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants