Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator health #994

Merged
merged 9 commits into from
Mar 12, 2023
Merged

Validator health #994

merged 9 commits into from
Mar 12, 2023

Conversation

Hitenjain14
Copy link
Member

Fixes

Fixed the validator health txn .

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #994 (c982dbc) into staging (f3daf59) will decrease coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #994      +/-   ##
===========================================
- Coverage    26.13%   26.06%   -0.07%     
===========================================
  Files           76       76              
  Lines         7760     7760              
===========================================
- Hits          2028     2023       -5     
- Misses        5460     5465       +5     
  Partials       272      272              
Flag Coverage Δ
Unit-Tests 26.06% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit fabc4ca into staging Mar 12, 2023
@dabasov dabasov deleted the validator-health branch March 12, 2023 20:54
peterlimg added a commit that referenced this pull request Mar 13, 2023
* staging:
  Modify/fmt leaf hash calculation (#912)
  Validator health (#994)
peterlimg added a commit that referenced this pull request Mar 13, 2023
* staging:
  Modify/fmt leaf hash calculation (#912)
  Validator health (#994)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants