Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/auth binding #1166

Merged
merged 4 commits into from Aug 22, 2023
Merged

Fix/auth binding #1166

merged 4 commits into from Aug 22, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Aug 10, 2023

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@dabasov dabasov changed the base branch from staging to sprint-july-4 August 10, 2023 12:33
@dabasov dabasov changed the base branch from sprint-july-4 to sprint-1.10 August 21, 2023 11:52
cnlangzi
cnlangzi suggested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest extract old code to HttpAuthorizer as default value instead removing it. Because it should work on Bolt(web). It is only be changed with bluetooth implementation on Bolt(iOS/Android).

@dabasov dabasov merged commit b346dcd into sprint-1.10 Aug 22, 2023
12 checks passed
@dabasov dabasov deleted the fix/auth-binding branch August 22, 2023 13:02
@dabasov
Copy link
Member Author

dabasov commented Aug 22, 2023

create an issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnlangzi cnlangzi cnlangzi requested changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dabasov @cnlangzi @Jayashsatolia403