Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/download in WinSDK #1200

Merged
merged 5 commits into from Aug 31, 2023
Merged

Feat/download in WinSDK #1200

merged 5 commits into from Aug 31, 2023

Conversation

cnlangzi
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@cnlangzi cnlangzi changed the base branch from staging to sprint-1.10 August 30, 2023 10:00
@cnlangzi cnlangzi changed the title Feat/download win sdk Feat/download in WinSDK Aug 30, 2023
dabasov
dabasov approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 08d1c1a into sprint-1.10 Aug 31, 2023
12 checks passed
@dabasov dabasov deleted the feat/download_win_sdk branch August 31, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: err: blsSecretKeySetByCSPRIG error in windows cli
2 participants
@cnlangzi @dabasov