Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle failed sc txns by treating them as error #247

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

bbist
Copy link
Contributor

@bbist bbist commented Sep 14, 2021

This PR fixes the issue 0chain/zboxcli#53 once the PR 0chain/0chain#523 is merged to 0chain core repo.

@bbist bbist requested a review from Sriep September 14, 2021 10:06
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 96d669e into staging Sep 16, 2021
@cnlangzi cnlangzi deleted the fix/sc-txn-errors branch September 16, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants