Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mobile): check allocation to prevent panicking #681

Merged
merged 4 commits into from
Dec 10, 2022
Merged

fix(mobile): check allocation to prevent panicking #681

merged 4 commits into from
Dec 10, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Dec 9, 2022

Changes

Fixes

  • fixed panicking issue on allocation's methods

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@cnlangzi cnlangzi merged commit 6c52d71 into staging Dec 10, 2022
@cnlangzi cnlangzi deleted the fix/pancking_bulkBarrierPreWrite branch December 10, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cnlangzi @peterlimg