Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct failure reason for the duplicate file upload #803

Merged
merged 10 commits into from Mar 1, 2023

Conversation

Manish-210
Copy link
Contributor

Changes

-Using two channels one for the error message and other for the waitgroup in the chunked upload file to show correct error message to the user.

Fixes

-0chain/zboxcli#327

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

zboxcore/sdk/chunked_upload.go Outdated Show resolved Hide resolved
zboxcore/sdk/chunked_upload.go Outdated Show resolved Hide resolved
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests correct_upload_failure_reason
gosdk correct_failure_reason
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests correct_upload_failure_reason
gosdk correct_failure_reason
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Manish-210 Manish-210 requested a review from dabasov March 1, 2023 11:55
@dabasov dabasov merged commit a4a17c3 into staging Mar 1, 2023
@dabasov dabasov deleted the correct_failure_reason branch March 1, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(error msg) downloadThumbnail method error File content didn't match with uploaded file
4 participants