Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make verify function public #907

Merged
merged 2 commits into from Apr 19, 2023
Merged

make verify function public #907

merged 2 commits into from Apr 19, 2023

Conversation

Sanchit011
Copy link
Collaborator

@Sanchit011 Sanchit011 commented Apr 19, 2023 •
edited

Changes

make verify function public

Fixes

fixed the failing unit tests in 0box

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

dabasov
dabasov approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sanchit011 Sanchit011 merged commit d92949e into staging Apr 19, 2023
11 checks passed
@Sanchit011 Sanchit011 deleted the fix/verify-function branch April 19, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sanchit011 @dabasov