Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(mobile) fix GetFileMetaFromAuthTicket and DownloadFromAuthTicket #960

Merged
merged 6 commits into from May 16, 2023
Merged

(mobile) fix GetFileMetaFromAuthTicket and DownloadFromAuthTicket #960

merged 6 commits into from May 16, 2023

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented May 13, 2023 •
edited

Changes

fixes for mobile/zbox

DownloadFromAuthTicket
GetFileMetaFromAuthTicket
ListDirFromAuthTicket

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@boddumanohar boddumanohar force-pushed the fix/GetFileMetaFromAuthTicket branch from 287c031 to 810764e Compare May 13, 2023 16:21
@boddumanohar boddumanohar force-pushed the fix/GetFileMetaFromAuthTicket branch from 810764e to 3498435 Compare May 13, 2023 16:23
@boddumanohar boddumanohar changed the title (mobile) fix GetFileMetaFromAuthTicket (mobile) fix GetFileMetaFromAuthTicket and DownloadFromAuthTicket May 13, 2023
@boddumanohar boddumanohar force-pushed the fix/GetFileMetaFromAuthTicket branch from 458fc57 to e84e9b8 Compare May 13, 2023 20:39
dabasov
dabasov approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 2c185a7 into staging May 16, 2023
11 checks passed
@dabasov dabasov deleted the fix/GetFileMetaFromAuthTicket branch May 16, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boddumanohar @dabasov