Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add FileOptionsChanged to UpdateAllocationRequest #541

Merged
merged 1 commit into from Feb 11, 2023
Merged

add FileOptionsChanged to UpdateAllocationRequest #541

merged 1 commit into from Feb 11, 2023

Conversation

devyetii
Copy link
Collaborator

@devyetii devyetii mentioned this pull request Feb 10, 2023
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/allocation-file-options-not-supported-by-some-clients
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix/file-options-not-supported-by-some-sdk-clients
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/allocation-file-options-not-supported-by-some-clients
gosdk NOT OVERRIDDEN
zboxcli fix/file-options-not-supported-by-some-sdk-clients
zwalletcli staging
0chain fix/file-options-not-supported-by-some-sdk-clients
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Kishan-Dhakan
Kishan-Dhakan reviewed Feb 11, 2023
View reviewed changes
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add some tests for it?

@devyetii
Copy link
Collaborator Author

@Kishan-Dhakan Will be added here

@dabasov dabasov merged commit 6d65723 into master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@stewartie4 stewartie4 Awaiting requested review from stewartie4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devyetii @service-0chain @Kishan-Dhakan @dabasov