Add smoke tests mode #656
Merged
Add smoke tests mode #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -261,32 +218,6 @@ func createDefaultClientBridgeConfig(t *test.SystemTest) ([]string, error) { | |||
| ) | |||
| } | |||
|
|
|||
| func runCreateBridgeClientTestConfig( | |||
There was a problem hiding this comment.
Why are these being removed?
There was a problem hiding this comment.
they were unused functions
stewartie4
commented
Apr 29, 2023
| @@ -22,6 +24,7 @@ func TestCreateBucket(testSetup *testing.T) { | |||
| require.Equal(t, 200, resp.StatusCode()) | |||
| }) | |||
|
|
|||
| // FIXME - this should be 400 not 500 | |||
There was a problem hiding this comment.
@stewartie4 reminder to raise an issue for this
|
|
||
| t.Parallel() | ||
| // FIXME: we should never return a 500 to the end user |
There was a problem hiding this comment.
@stewartie4 reminder to raise an issue for this
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions PR: 0chain/actions#155
Smoke tests run: https://github.com/0chain/system_test/actions/runs/4838450707/jobs/8623002789
(this run also includes flaky tests so the run is longer than it will be in other repos)