Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interest pool sc #135

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Remove interest pool sc #135

merged 2 commits into from
Jun 3, 2022

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented May 31, 2022 •
edited

A brief description of the changes in this PR:
Remove all code related to interest pool smart contract and locking tokens

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced May 31, 2022
Merged
Merged
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests remove_interest_pool
gosdk remove_interest_pool
zboxcli staging
zwalletcli remove_interest_pool
0chain remove_interest_pool
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests remove_interest_pool
gosdk remove_interest_pool
zboxcli staging
zwalletcli remove_interest_pool
0chain remove_interest_pool
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

dabasov
dabasov approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov self-requested a review June 2, 2022 16:03
dabasov
dabasov approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sriep Sriep merged commit e301437 into staging Jun 3, 2022
@Sriep Sriep deleted the remove_interest_pool branch June 3, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sriep @service-0chain @dabasov