Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check balance before send transaction #138

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

Kishan-Dhakan
Copy link
Contributor

A brief description of the changes in this PR:

  • Checks for sufficient balance before sending tokens
  • Transaction does not fail even if getting balance does

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • 0chain:
  • Other: ...

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests feat/optimizeSend
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli feat/CheckBalanceForFastFailOnSend
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan linked an issue Jun 4, 2022 that may be closed by this pull request
@Kishan-Dhakan
Copy link
Contributor Author

Before:
image

After:
image
image

Copy link
Contributor

@stewartie4 stewartie4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant fix for #52

cmd/send.go Show resolved Hide resolved
@Kishan-Dhakan Kishan-Dhakan merged commit fcf5521 into staging Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Check balance before attempting to send ZCN
3 participants