Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed token nomination and updated transaction validation #140

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Fixed token nomination and updated transaction validation #140

merged 6 commits into from
Jun 17, 2022

Conversation

Dmdv
Copy link
Contributor

@Dmdv Dmdv commented Jun 6, 2022

A brief description of the changes in this PR:
#139

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • 0chain:
  • Other: ...

@Dmdv Dmdv requested a review from dabasov June 6, 2022 00:13
@Dmdv Dmdv self-assigned this Jun 6, 2022
@Dmdv Dmdv requested a review from ssardana08 June 7, 2022 15:35
@Dmdv Dmdv mentioned this pull request Jun 15, 2022
Closed
dabasov
dabasov approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dmdv Dmdv merged commit eb61a1e into staging Jun 17, 2022
@Dmdv Dmdv deleted the fix/bridge_burn branch June 17, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@ssardana08 ssardana08 Awaiting requested review from ssardana08

Assignees

@Dmdv Dmdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dmdv @dabasov