Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

make id flag mandatory for bridge-auth-config command' #169

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

boddumanohar
Copy link
Contributor

A brief description of the changes in this PR:

fixes: #167

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • 0chain:
  • Other: ...

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped YES
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli bridge-auth-config-fix
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov dabasov merged commit a1e149c into staging Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zwallet bridge-auth-config commands fails when id is not specified
4 participants