Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to register authorizers #170

Merged
merged 14 commits into from
Sep 29, 2022
Merged

Add command to register authorizers #170

merged 14 commits into from
Sep 29, 2022

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Aug 21, 2022

A brief description of the changes in this PR:

fixes: 0chain/0chain#1602

./zwallet auth-register \
--url http://dev.0chain.net:32302 \
--client_key 347efa09e2156aa8ddb4a0a581cb8e6fed0d6b9c9c8d38d2f1fdd119069a3512de33665d17ed8e742497615e3f7c9ab5f0de747884e14836ac9496ce12299f81 \
--client_id 4a53cfa74eb600e973d28af1eedc9213bc3a4e9f3af4fd289bd441f642fb540a

the added authoriser URL can be checked by running

./zwallet bridge-list-auth

[
  {
    "id": "2f945f7310689f17afd8c8cb291e1e3ba21677243aa1d404a2293064e7983d60",
    "url": "http://dev.0chain.net:32301"
  },
  {
    "id": "4a53cfa74eb600e973d28af1eedc9213bc3a4e9f3af4fd289bd441f642fb540a",
    "url": "http://dev.0chain.net:32302"
  }
]

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • 0chain:
  • Other: ...

@boddumanohar
Copy link
Contributor Author

Currently blocked by moving smartcontractinterface/interface.go#L34 to common. Will continue working once the interface is moved to common

@boddumanohar boddumanohar changed the title Register authorizers [WIP] Register authorizers Aug 23, 2022
@boddumanohar boddumanohar marked this pull request as draft August 23, 2022 15:46
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uneet7 uneet7 marked this pull request as ready for review September 13, 2022 10:02
@uneet7 uneet7 changed the title [WIP] Register authorizers Add command to register authorizers Sep 13, 2022
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli register-authorizers
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped YES
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli register-authorizers
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 43309cb into staging Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register authorizers
4 participants