Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove events command #183

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Remove events command #183

merged 2 commits into from
Sep 30, 2022

Conversation

uneet7
Copy link
Contributor

@uneet7 uneet7 commented Sep 28, 2022

A brief description of the changes in this PR:
Fixes
#179

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • 0chain:
  • Other: ...

@uneet7 uneet7 linked an issue Sep 28, 2022 that may be closed by this pull request
remove command ./zwallet events #179
Closed
@uneet7 uneet7 changed the title Remvoe events command Remove events command Sep 28, 2022
cnlangzi
cnlangzi approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit f3c0bd9 into staging Sep 30, 2022
@cnlangzi cnlangzi deleted the 179-remove-command-zwallet-events branch September 30, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnlangzi cnlangzi cnlangzi approved these changes

@dabasov dabasov Awaiting requested review from dabasov

@boddumanohar boddumanohar Awaiting requested review from boddumanohar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove command ./zwallet events
2 participants
@uneet7 @cnlangzi