Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zcncore): used zcncore.MakeSCRestAPICall #207

Merged
merged 13 commits into from
Feb 1, 2023

Conversation

cnlangzi
Copy link
Contributor

Changes

Fixes

  • speed up get info from sharders

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/speed_up_txn_confirm
gosdk fix/speed_up_txn_confirm
zboxcli fix/speed_up_txn_confirm
zwalletcli fix/speed_up_txn_confirm
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/speed_up_txn_confirm
gosdk fix/speed_up_txn_confirm
zboxcli fix/speed_up_txn_confirm
zwalletcli fix/speed_up_txn_confirm
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/speed_up_txn_confirm
gosdk fix/speed_up_txn_confirm
zboxcli fix/speed_up_txn_confirm
zwalletcli fix/speed_up_txn_confirm
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 4f2248b into staging Feb 1, 2023
@cnlangzi cnlangzi deleted the fix/speed_up_txn_confirm branch February 1, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants