Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat_Add pagination for miners and sharders #210

Merged
merged 24 commits into from
Mar 13, 2023
Merged

Feat_Add pagination for miners and sharders #210

merged 24 commits into from
Mar 13, 2023

Conversation

K-Kumar-01
Copy link
Contributor

Closes #203

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

peterlimg
peterlimg requested changes Feb 17, 2023
View reviewed changes
cmd/minersc.go Show resolved Hide resolved
cmd/minersc.go Show resolved Hide resolved
cmd/minersc.go Outdated Show resolved Hide resolved
@K-Kumar-01
feat: add all flag for miners
184cf76 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
peterlimg
peterlimg requested changes Feb 26, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh @K-Kumar-01, sorry, part of my last reviews didn't get submitted, please re-check.

cmd/minersc.go Outdated Show resolved Hide resolved
@K-Kumar-01
fix: logic to fetch all sharders
fb63201 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
Merge branch 'staging' of https://github.com/0chain/zwalletcli into s…
53fd171 
…taging
@K-Kumar-01
Merge branch 'staging' into k-kumar-01/i203/add-pagination-miners-and…
d8e237c 
…-sharders
@K-Kumar-01
fix:merge conflict
50e0dd6 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
dabasov
dabasov approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

peterlimg
peterlimg approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peterlimg
peterlimg reviewed Mar 1, 2023
View reviewed changes
cmd/minersc.go Outdated Show resolved Hide resolved
Kishan-Dhakan
Kishan-Dhakan suggested changes Mar 6, 2023
View reviewed changes
cmd/minersc.go Outdated Show resolved Hide resolved
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk k-kumar-01/feat/miners-and-sharders-list-functions-update
zboxcli staging
zwalletcli k-kumar-01/i203/add-pagination-miners-and-sharders
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests pagination-pr
gosdk k-kumar-01/feat/miners-and-sharders-list-functions-update
zboxcli staging
zwalletcli k-kumar-01/i203/add-pagination-miners-and-sharders
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan mentioned this pull request Mar 12, 2023
Merged
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests pagination-pr
gosdk k-kumar-01/feat/miners-and-sharders-list-functions-update
zboxcli staging
zwalletcli k-kumar-01/i203/add-pagination-miners-and-sharders
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit 72b1338 into staging Mar 13, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the k-kumar-01/i203/add-pagination-miners-and-sharders branch March 13, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov dabasov approved these changes

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ls-miners and ls-sharders only return first 20
5 participants
@K-Kumar-01 @service-0chain @dabasov @Kishan-Dhakan @peterlimg