Skip to content

Commit

Permalink
mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-check…
Browse files Browse the repository at this point in the history
…patch-fixes

WARNING: Missing a blank line after declarations
torvalds#34: FILE: include/linux/page_idle.h:50:
+	struct page_ext *page_ext;
+	page_ext = lookup_page_ext(page);

WARNING: Missing a blank line after declarations
torvalds#45: FILE: include/linux/page_idle.h:60:
+	struct page_ext *page_ext;
+	page_ext = lookup_page_ext(page);

WARNING: Missing a blank line after declarations
torvalds#57: FILE: include/linux/page_idle.h:70:
+	struct page_ext *page_ext;
+	page_ext = lookup_page_ext(page);

WARNING: Missing a blank line after declarations
torvalds#68: FILE: include/linux/page_idle.h:80:
+	struct page_ext *page_ext;
+	page_ext = lookup_page_ext(page);

WARNING: Missing a blank line after declarations
torvalds#79: FILE: include/linux/page_idle.h:90:
+	struct page_ext *page_ext;
+	page_ext = lookup_page_ext(page);

WARNING: Missing a blank line after declarations
torvalds#90: FILE: include/linux/page_idle.h:100:
+	struct page_ext *page_ext;
+	page_ext = lookup_page_ext(page);

total: 1 errors, 6 warnings, 196 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Yang Shi <yang.shi@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed May 26, 2016
1 parent cd42b99 commit 1bc9fb4
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions include/linux/page_idle.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ extern struct page_ext_operations page_idle_ops;

static inline bool page_is_young(struct page *page)
{
struct page_ext *page_ext;
page_ext = lookup_page_ext(page);
struct page_ext *page_ext = lookup_page_ext(page);

if (unlikely(!page_ext))
return false;

Expand All @@ -56,8 +56,8 @@ static inline bool page_is_young(struct page *page)

static inline void set_page_young(struct page *page)
{
struct page_ext *page_ext;
page_ext = lookup_page_ext(page);
struct page_ext *page_ext = lookup_page_ext(page);

if (unlikely(!page_ext))
return;

Expand All @@ -66,8 +66,8 @@ static inline void set_page_young(struct page *page)

static inline bool test_and_clear_page_young(struct page *page)
{
struct page_ext *page_ext;
page_ext = lookup_page_ext(page);
struct page_ext *page_ext = lookup_page_ext(page);

if (unlikely(!page_ext))
return false;

Expand All @@ -76,8 +76,8 @@ static inline bool test_and_clear_page_young(struct page *page)

static inline bool page_is_idle(struct page *page)
{
struct page_ext *page_ext;
page_ext = lookup_page_ext(page);
struct page_ext *page_ext = lookup_page_ext(page);

if (unlikely(!page_ext))
return false;

Expand All @@ -86,8 +86,8 @@ static inline bool page_is_idle(struct page *page)

static inline void set_page_idle(struct page *page)
{
struct page_ext *page_ext;
page_ext = lookup_page_ext(page);
struct page_ext *page_ext = lookup_page_ext(page);

if (unlikely(!page_ext))
return;

Expand All @@ -96,8 +96,8 @@ static inline void set_page_idle(struct page *page)

static inline void clear_page_idle(struct page *page)
{
struct page_ext *page_ext;
page_ext = lookup_page_ext(page);
struct page_ext *page_ext = lookup_page_ext(page);

if (unlikely(!page_ext))
return;

Expand Down

0 comments on commit 1bc9fb4

Please sign in to comment.