Skip to content

Commit

Permalink
drm: nouveau: lsfw: cleanup coccinelle warning
Browse files Browse the repository at this point in the history
odd_ptr_err.cocci has complained about this warning for a long time:
lsfw.c:194:5-11: inconsistent IS_ERR and PTR_ERR on line 195.

Although there is no actual impact, it can improve scanning efficiency.

Signed-off-by: Wang Qing <wangqing@vivo.com>
  • Loading branch information
Wang Qing authored and intel-lab-lkp committed Dec 14, 2021
1 parent 99b03ca commit 3a85ab7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
Expand Up @@ -191,7 +191,8 @@ nvkm_acr_lsfw_load_bl_inst_data_sig(struct nvkm_subdev *subdev,
u32 *bldata;
int ret;

if (IS_ERR((lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id))))
lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id);
if (IS_ERR(lsfw)
return PTR_ERR(lsfw);

ret = nvkm_firmware_load_name(subdev, path, "bl", ver, &bl);
Expand Down

0 comments on commit 3a85ab7

Please sign in to comment.