Skip to content

Commit

Permalink
soc: qcom: aoss: Expose send for generic usecase
Browse files Browse the repository at this point in the history
Not all upcoming usecases will have an interface to allow the aoss
driver to hook onto. Expose the send api and create a get function to
enable drivers to send their own messages to aoss.

Signed-off-by: Chris Lew <clew@codeaurora.org>
Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org>
  • Loading branch information
Deepak Kumar Singh authored and intel-lab-lkp committed Apr 9, 2021
1 parent 17e7124 commit 57a0c1a
Show file tree
Hide file tree
Showing 2 changed files with 82 additions and 1 deletion.
50 changes: 49 additions & 1 deletion drivers/soc/qcom/qcom_aoss.c
Expand Up @@ -8,10 +8,12 @@
#include <linux/io.h>
#include <linux/mailbox_client.h>
#include <linux/module.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/pm_domain.h>
#include <linux/thermal.h>
#include <linux/slab.h>
#include <linux/soc/qcom/qcom_aoss.h>

#define QMP_DESC_MAGIC 0x0
#define QMP_DESC_VERSION 0x4
Expand Down Expand Up @@ -61,6 +63,7 @@ struct qmp_cooling_device {
* @mbox_chan: mailbox channel used to ring the doorbell on transmit
* @offset: offset within @msgram where messages should be written
* @size: maximum size of the messages to be transmitted
* @orphan: tarcks whether qmp handle is valid
* @event: wait_queue for synchronization with the IRQ
* @tx_lock: provides synchronization between multiple callers of qmp_send()
* @qdss_clk: QDSS clock hw struct
Expand All @@ -76,6 +79,7 @@ struct qmp {

size_t offset;
size_t size;
atomic_t orphan;

wait_queue_head_t event;

Expand Down Expand Up @@ -223,11 +227,17 @@ static bool qmp_message_empty(struct qmp *qmp)
*
* Return: 0 on success, negative errno on failure
*/
static int qmp_send(struct qmp *qmp, const void *data, size_t len)
int qmp_send(struct qmp *qmp, const void *data, size_t len)
{
long time_left;
int ret;

if (WARN_ON(IS_ERR_OR_NULL(qmp) || !data))
return -EINVAL;

if (atomic_read(&qmp->orphan))
return -EINVAL;

if (WARN_ON(len + sizeof(u32) > qmp->size))
return -EINVAL;

Expand Down Expand Up @@ -261,6 +271,7 @@ static int qmp_send(struct qmp *qmp, const void *data, size_t len)

return ret;
}
EXPORT_SYMBOL(qmp_send);

static int qmp_qdss_clk_prepare(struct clk_hw *hw)
{
Expand Down Expand Up @@ -515,6 +526,40 @@ static void qmp_cooling_devices_remove(struct qmp *qmp)
thermal_cooling_device_unregister(qmp->cooling_devs[i].cdev);
}

/**
* qmp_get() - get a qmp handle from a device
* @dev: client device pointer
*
* Return: handle to qmp device on success, ERR_PTR() on failure
*/
struct qmp *qmp_get(struct device *dev)
{
struct platform_device *pdev;
struct device_node *np;
struct qmp *qmp;

if (!dev || !dev->of_node)
return ERR_PTR(-EINVAL);

np = of_parse_phandle(dev->of_node, "qcom,qmp", 0);
if (!np)
return ERR_PTR(-ENODEV);

pdev = of_find_device_by_node(np);
if (!pdev)
return ERR_PTR(-EINVAL);

qmp = platform_get_drvdata(pdev);
return qmp ? qmp : ERR_PTR(-EPROBE_DEFER);
}
EXPORT_SYMBOL(qmp_get);

void qmp_put(struct platform_device *pdev)
{
platform_device_put(pdev);
}
EXPORT_SYMBOL(qmp_put);

static int qmp_probe(struct platform_device *pdev)
{
struct resource *res;
Expand Down Expand Up @@ -569,6 +614,8 @@ static int qmp_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, qmp);

atomic_set(&qmp->orphan, 0);

return 0;

err_remove_qdss_clk:
Expand All @@ -590,6 +637,7 @@ static int qmp_remove(struct platform_device *pdev)
qmp_cooling_devices_remove(qmp);

qmp_close(qmp);
atomic_set(&qmp->orphan, 1);
mbox_free_channel(qmp->mbox_chan);

return 0;
Expand Down
33 changes: 33 additions & 0 deletions include/linux/soc/qcom/qcom_aoss.h
@@ -0,0 +1,33 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/*
* Copyright (c) 2020, The Linux Foundation. All rights reserved.
*/

#ifndef __QCOM_AOSS_H__
#define __QCOM_AOSS_H__

#include <linux/err.h>
#include <linux/device.h>

struct qmp;

#if IS_ENABLED(CONFIG_QCOM_AOSS_QMP)

int qmp_send(struct qmp *qmp, const void *data, size_t len);
struct qmp *qmp_get(struct device *dev);

#else

static inline int qmp_send(struct qmp *qmp, const void *data, size_t len)
{
return -ENODEV;
}

static inline struct qmp *qmp_get(struct device *dev)
{
return ERR_PTR(-ENODEV);
}

#endif

#endif

0 comments on commit 57a0c1a

Please sign in to comment.