Skip to content

Commit

Permalink
mISDN: Use LIST_HEAD() for list_head
Browse files Browse the repository at this point in the history
There's no need to declare a list and then init it manually,
just use the LIST_HEAD() macro.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
  • Loading branch information
Shixin Liu authored and intel-lab-lkp committed Mar 29, 2021
1 parent 3847d46 commit 84af06f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
7 changes: 2 additions & 5 deletions drivers/isdn/mISDN/dsp_core.c
Expand Up @@ -177,8 +177,8 @@ MODULE_LICENSE("GPL");
/*int spinnest = 0;*/

DEFINE_SPINLOCK(dsp_lock); /* global dsp lock */
struct list_head dsp_ilist;
struct list_head conf_ilist;
struct LIST_HEAD(dsp_ilist);
struct LIST_HEAD(conf_ilist);
int dsp_debug;
int dsp_options;
int dsp_poll, dsp_tics;
Expand Down Expand Up @@ -1169,9 +1169,6 @@ static int __init dsp_init(void)
printk(KERN_INFO "mISDN_dsp: DSP clocks every %d samples. This equals "
"%d jiffies.\n", dsp_poll, dsp_tics);

INIT_LIST_HEAD(&dsp_ilist);
INIT_LIST_HEAD(&conf_ilist);

/* init conversion tables */
dsp_audio_generate_law_tables();
dsp_silence = (dsp_options & DSP_OPT_ULAW) ? 0xff : 0x2a;
Expand Down
4 changes: 1 addition & 3 deletions drivers/isdn/mISDN/l1oip_core.c
Expand Up @@ -230,7 +230,7 @@ static const char *l1oip_revision = "2.00";

static int l1oip_cnt;
static DEFINE_SPINLOCK(l1oip_lock);
static struct list_head l1oip_ilist;
static LIST_HEAD(l1oip_ilist);

#define MAX_CARDS 16
static u_int type[MAX_CARDS];
Expand Down Expand Up @@ -1440,8 +1440,6 @@ l1oip_init(void)
printk(KERN_INFO "mISDN: Layer-1-over-IP driver Rev. %s\n",
l1oip_revision);

INIT_LIST_HEAD(&l1oip_ilist);

if (l1oip_4bit_alloc(ulaw))
return -ENOMEM;

Expand Down

0 comments on commit 84af06f

Please sign in to comment.