Skip to content

Commit

Permalink
backlight: lp855x: Switch to atomic PWM API
Browse files Browse the repository at this point in the history
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and
replace it for the atomic PWM API.

Signed-off-by: Maíra Canal <maira.canal@usp.br>
  • Loading branch information
mairacanal authored and intel-lab-lkp committed Oct 30, 2021
1 parent 3976e97 commit f4d53f4
Showing 1 changed file with 10 additions and 13 deletions.
23 changes: 10 additions & 13 deletions drivers/video/backlight/lp855x_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,8 @@ static int lp855x_configure(struct lp855x *lp)

static void lp855x_pwm_ctrl(struct lp855x *lp, int br, int max_br)
{
unsigned int period = lp->pdata->period_ns;
unsigned int duty = br * period / max_br;
struct pwm_device *pwm;
struct pwm_device *pwm = NULL;
struct pwm_state state;

/* request pwm device with the consumer name */
if (!lp->pwm) {
Expand All @@ -245,18 +244,16 @@ static void lp855x_pwm_ctrl(struct lp855x *lp, int br, int max_br)

lp->pwm = pwm;

/*
* FIXME: pwm_apply_args() should be removed when switching to
* the atomic PWM API.
*/
pwm_apply_args(pwm);
pwm_init_state(lp->pwm, &state);
state.period = lp->pdata->period_ns;
}

pwm_config(lp->pwm, duty, period);
if (duty)
pwm_enable(lp->pwm);
else
pwm_disable(lp->pwm);
pwm_get_state(lp->pwm, &state);

state.duty_cycle = br * state.period / max_br;
state.enabled = state.duty_cycle;

pwm_apply_state(lp->pwm, &state);
}

static int lp855x_bl_update_status(struct backlight_device *bl)
Expand Down

0 comments on commit f4d53f4

Please sign in to comment.