Detect gamepath automatically

[0neGal]

Combined #51 and #52 into one.

[0neGal]

I've no clue if this actually works on the Windows side of things, but it may or may not function...

[Alystrasz]

I think we should export all find-my-game-folder related code to a given module/method.
The way it is currently done, on first launch, "game path is not set!" message will be displayed to the user, whereas path will be found straight after dialog is closed.

[0neGal]

If you could test whether it still functions as it should after my last commit that'd be nice, I implemented the Promise exec() as you asked, and moved requests.js into extras/ along with putting the auto game path stuff into it's own file as well.

The way it is currently done, on first launch, "game path is not set!" message will be displayed to the user, whereas path will be found straight after dialog is closed.

I noticed this too, not ideal and it'll confuse the user...

[3top1a]

It appears that the VDF reading was broken, so I've made a pull request (#54)

[Alystrasz]

If you could test whether it still functions as it should after my last commit that'd be nice

I made a PR (#55) to fix little typos and make this work on Windows (tested and approved).

[0neGal]

It'd be lovely if somebody could verify the VDF part also works just fine...

[Alystrasz]

Unfortunately, I don't have tf2 on Steam.
And it's not on sale right now (30 bucks, seriously ?!)

[0neGal]

Unfortunately, I don't have tf2 on Steam.

Perhaps @3top1a does?

And it's not on sale right now (30 bucks, seriously ?!)

Usually get put on sale down to around 5$/€, and there's Lunar sale in like, 4-5 days... But don't buy it if you don't need it :)

[Alystrasz]

If its price goes around 5€, I'll buy it for sure!
It's still useful to have different game versions, to be able to test them all when developing related software, for instance 😄

[3top1a]

Unfortunately, I don't have tf2 on Steam.

Perhaps @3top1a does?

#34 (comment)

In the original test code you can see it working, and last time I checked (#54 ) it did work (I have the steam version)

[0neGal]

@Alystrasz, general.missingpath has been reworded to: Game location could not be found automatically! Please select it manually!, if you could update the French translation I'll go ahead and merge this :)

[Alystrasz]

Before you merge, I found some issues:

• "Game path" link to change folder path does not work anymore;
• Mods support does not work on first launch (maybe because modpath is loaded before path selection:

  viper/src/utils.js

  Line 340 in 18d1166

  let modpath = path.join(settings.gamepath, "R2Northstar/mods");

[0neGal]

"Game path" link to change folder path does not work anymore;

On the topic of this, perhaps we should change the text to Change Gamepath, as just Game path doesn't really say what the button does.

[Alystrasz]

"Game path" link to change folder path does not work anymore;

On the topic of this, perhaps we should change the text to Change Gamepath, as just Game path doesn't really say what the button does.

Agreed, I had several people who thought Viper was not working because it "kept asking them about their game path".

[0neGal]

Agreed, I had several people who thought Viper was not working because it "kept asking them about their game path".

Hence why the new alert string (which I just noticed uses alert() a non-existing function instead of winAlert(), fixing it rn :p) makes so much more sense

[0neGal]

I think everything is working just as intended, that is if the auto detection works, but I trust your words on that, hence I'll be merging this...