Bootstrap e2e tests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-lee
commented
Apr 14, 2023
dan-lee
force-pushed
the
chore/add-e2e-tests
branch
2 times, most recently
from
314e7aa
to
6d2bf86
Compare
|
Updated to a monorepo in #33 as this PR broke changesets and publishing in general |
dan-lee
force-pushed
the
chore/add-e2e-tests
branch
from
6d2bf86
to
bd14774
Compare
|
Rebased! Should I add it to the Github Action? |
dan-lee
force-pushed
the
chore/add-e2e-tests
branch
from
87ac7d9
to
0eab553
Compare
|
@JoviDeCroock should be good to merge now 馃コ |
JoviDeCroock
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project still amazes me 馃ぉ
I think tests are a crucial part of any project, so I added a basic smoke e2e test to build upon.
Bootstrapping was the most challenging part, so I hope this can pave the way for more in-depth tests.
What does it do?
It opens a
tsserverinstance in the project that should be tested and opens/saves a file and checks if the generated file was created and imported.How to run
It can be run via
pnpm test:e2e, everything else should be done automatically.Be aware that the test takes some time (because of
tsserver), around ~5 secs on my M1 machine for this test alone.Any feedback is greatly appreciated
Addresses issue #22