Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persisted): nested persisted operation resolution #330

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jun 7, 2024

Fixes #329

Brings us more inline by using unrolltadafragment

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 007a624

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@0no-co/graphqlsp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock requested a review from kitten June 7, 2024 10:22
@JoviDeCroock JoviDeCroock changed the title fix nested persisted operation resolution fix(persisted): nested persisted operation resolution Jun 7, 2024
Comment on lines +178 to +185
let text = resolveTemplate(
templateLiteral,
foundFilename,
info
).combinedText;
fragments.forEach(fragmentDefinition => {
text = `${text}\n\n${print(fragmentDefinition)}`;
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need this reparsed to normalize the output, I think

@JoviDeCroock JoviDeCroock merged commit 7768286 into main Jun 7, 2024
1 check passed
@JoviDeCroock JoviDeCroock deleted the nested-fragments-persisted branch June 7, 2024 11:41
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persisted document hashes do not include recursive fragments
2 participants