Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): Improve loader by adding a merged loader and incorporating SchemaOrigin parsing #165

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 28, 2024

Summary

This merges the SchemaOrigin type into @gql.tada/internal and merges both loaders into one. It also changes the loader interface to automatically reload schemas & introspections on updates and to add a single method to load both the schema and the introspection.

The latter methods are now marked as internal and won't reload the internal data.

Set of changes

  • Add .load() to loaders`
  • Mark old loading methods as internal
  • Reload schema/introspection data when watcher notifies
  • Add merged load() function that accepts SchemaOrigin

Copy link

changeset-bot bot commented Mar 28, 2024

🦋 Changeset detected

Latest commit: 6c5a944

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit 6d04115 into main Mar 28, 2024
1 check passed
@kitten kitten deleted the fix/loader-improvements branch March 28, 2024 20:32
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants