Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update build to add bundled licenses of internalized modules #175

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Apr 5, 2024

Summary

As discussed, we currently internalize modules but should include a refrence to them in the bundled license text.

In general, internalizing modules is done because gql.tada installs the CLI (and in the future; other dependencies) automatically and should remain compact without making what it pulls in or itself too heavy.
We aim to only do this for dependencies that are replaceable for custom purposes or are there as stand-ins temporary (e.g. duplicates of what typescript could already do, but what we haven't implemented via typescript yet)

We can review this before reaching a 1.0.0 milestone on @gql.tada/internal and @gql.tada/cli-utils, at which point we're able to identify more options to not internalize modules to keep their statistics on npm intact.

Set of changes

  • Add collecting licenses to rollup
  • Update licenses

@kitten kitten requested a review from JoviDeCroock April 5, 2024 12:03
Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: 8bde1b9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit 1a0b07b into main Apr 5, 2024
2 checks passed
@kitten kitten deleted the chore/build-bundled-license branch April 5, 2024 12:35
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants