fix: support opting out of the includeDeprecated argument #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bd1441e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
force-pushed
the
support-opting-out-include-deprecated
branch
from
b439e27
to
5b7c284
Compare
JoviDeCroock
force-pushed
the
support-opting-out-include-deprecated
branch
from
5b7c284
to
bc78ad4
Compare
JoviDeCroock
force-pushed
the
support-opting-out-include-deprecated
branch
from
8dfb062
to
bd1441e
Compare
kitten
approved these changes
Apr 12, 2024
|
I have patch my package locally and can confirm that this PR fixes #189. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #189
Summary
In the October 2021 spec
__Field.argsand__Directive.argsaren't explicitly said to supportincludeDeprecated: Booleanas an argument.https://spec.graphql.org/October2021/#sec-The-__Field-Type
https://spec.graphql.org/October2021/#sec-The-__Directive-Type
vs
https://spec.graphql.org/draft/#sec-The-__Field-Type
https://spec.graphql.org/draft/#sec-The-__Directive-Type