fix: Remove redundant constraints on IntrospectionQuery causing TS perf bottlenecks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ffc7a9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jan 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22
Summary
This removes any unnecessary and redundant constraints in
IntrospectionQuery, which previously forced TypeScript to recursively check the inputIntrospectionQuerydata (i.e. the schema data a user gives us) against the constraint type.This meant that TypeScript was spending a lot of time in
recursiveTypeRelatedTo, only to recursively unroll an introspection schema that we were mapping and checking anyway.Instead, this constraint is now removed and also doesn't affect code paths that run after
mapIntrospectionhas run already.Set of changes
argsfromIntrospectionFieldinterfacesfromIntrospectionObjectTypeandIntrospectionInterfaceTypetypesconstraint toreadonly any[]inIntrospectionSchema