fix(cli-utils): Add missing deduplication and normalization to generate persisted
output
#275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds missing fragment deduplication to the
generate-persisted
output, and also addsparse(print())
normalization to the initial document string. The latter can be disabled now using the--disable-normalization
argument, but it's unlikely that anyone would want to disable this.Note
I noticed that
unrollTadaFragments
pre-parses the document. As the function isn't used ingraphqlsp
itself that's likely unnecessary. Removing this allows us to surface parsing errors as warnings to users. That's a separate TODO from this change though.Set of changes
generate persisted
command--disable-normalization
argument