-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement @_unmask
directives to unmask fragment types
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 008c137 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@unmask
directives to unmask fragment types
@unmask
directives to unmask fragment types@_unmask
directives to unmask fragment types
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
JoviDeCroock
approved these changes
Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #28
Resolves #23
Summary
Fragments will now not be masked when they’re annotated with
@_unmask
. This will cause all their types derived byFragmentOf<>
and in parent documents to be fully unwrapped and unmasked.This PR also improves the readability of the
TodoDocumentNode
generics. Instead of the third generic being a full fragment definition, it'll now be displayed with a different syntax, i.e.Set of changes
$tada.definition
)@_unmask
directive@_unmask
directives from fragment definitions