Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing case for input object fields with default value #73

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Feb 23, 2024

Resolve #71

Summary

The case of defaultValue not being null | undefined wasn't being handled when deriving types for input object fields in variables.
This PR adds the missing match.

Set of changes

  • Add match for defaultValue to input objects’ fields

Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: a3858bf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit f958b91 into main Feb 24, 2024
2 checks passed
@kitten kitten deleted the fix/input-value-default-value branch February 24, 2024 07:02
@github-actions github-actions bot mentioned this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

required arguments with default values shouldn't be required in operation variables
2 participants