Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export $tada to fix isolatedModules projects #99

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 2, 2024

Summary

This is required for projects that are configured with isolatedModules: true.
When this is set, the $tada symbols can't be referenced and hence an error is emitted by tsserver/tsc.

Exporting $tada fixes this.

Set of changes

  • Re-export $tada
  • Mark $tada as @internal in ts docs

@kitten kitten requested a review from JoviDeCroock March 2, 2024 12:13
Copy link

changeset-bot bot commented Mar 2, 2024

🦋 Changeset detected

Latest commit: 5a5d4e5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit f0b666b into main Mar 2, 2024
2 checks passed
@kitten kitten deleted the fix/isolated-modules branch March 2, 2024 13:13
@github-actions github-actions bot mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants