Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the @ts-ignore directive on TS import in type declaration output #27

Merged
merged 3 commits into from Apr 18, 2024

Conversation

IvanUkhov
Copy link
Contributor

Hello,

Currently, the following directive is produced:

/*!@ts-ignore*/

However, it is not recognized by the compiler due to the exclamation mark in front.

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 051731c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@0no-co/graphql.web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's odd this definitely used to work in a past version of TypeScript, but I indeed just went back to test this and this isn't working properly anymore.

Nice catch!

@IvanUkhov
Copy link
Contributor Author

Thank you! There is a similar line in urql/core. Should I update it, or will you do it?

@kitten kitten changed the title Fix the directive syntax for ignoring errors due to unavailable peer dependencies Fix the @ts-ignore directive output on TS import in type declaration output Apr 18, 2024
@kitten kitten changed the title Fix the @ts-ignore directive output on TS import in type declaration output Fix the @ts-ignore directive on TS import in type declaration output Apr 18, 2024
@kitten kitten merged commit 0a4fef7 into 0no-co:main Apr 18, 2024
1 check passed
@kitten
Copy link
Member

kitten commented Apr 18, 2024

I can take care of that, if you'd like, no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants