Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for hoofd/preact still import "react" #52

Closed
lucacasonato opened this issue Aug 8, 2021 · 1 comment · Fixed by #54
Closed

Types for hoofd/preact still import "react" #52

lucacasonato opened this issue Aug 8, 2021 · 1 comment · Fixed by #54

Comments

@lucacasonato
Copy link

lucacasonato commented Aug 8, 2021

hoofd and hoofd/preact share typings. This has the unfortunate effect that dist/index.d.ts in the package that is published to NPM has a import("react"), even if I use preact. See line 25: https://unpkg.com/browse/hoofd@1.3.1/dist/index.d.ts

@JoviDeCroock
Copy link
Member

Hmm, you're right but I honestly don't know what to do about that, TypeScript doesn't give access to the compiler so generally the alias doesn't apply 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants