Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(types) - remove react reference from hoofd/preact #54

Merged
merged 2 commits into from
Aug 27, 2021
Merged

(types) - remove react reference from hoofd/preact #54

merged 2 commits into from
Aug 27, 2021

Conversation

JoviDeCroock
Copy link
Member

Fixes #52

@lucacasonato I think this might fix your issue

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021 •
edited
Loading

Size Change: 0 B

Total Size: 8.15 kB

ℹ️ View Unchanged
Filename Size Change
dist/hoofd.js 2.03 kB 0 B
dist/hoofd.modern.js 1.99 kB 0 B
dist/hoofd.module.js 2.05 kB 0 B
dist/hoofd.umd.js 2.08 kB 0 B

compressed-size-action

lucacasonato
lucacasonato approved these changes Aug 27, 2021
View reviewed changes
Copy link

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoviDeCroock JoviDeCroock merged commit 9f35a5a into main Aug 27, 2021
@JoviDeCroock JoviDeCroock deleted the preact-types branch August 27, 2021 11:11
@JoviDeCroock
Copy link
Member Author

@lucacasonato published as 1.4.0 thank you for checking so fast! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types for hoofd/preact still import "react"
2 participants
@JoviDeCroock @lucacasonato