Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

make useLink concurrent safe #79

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 27, 2023

Resolve #69

Rather than always looking for an existing link we'll assume that when we come from hydration we'll see data-hoofd: "1" which we'll then take over and hydrate with. Not entirely sure whether this is a breaking change yet 馃槄 it does solve our concurrent mode problems

Example: https://codesandbox.io/s/priceless-villani-lletf8?file=/src/App.js:174-239

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

Size Change: +392 B (4%)

Total Size: 9.24 kB

Filename Size Change
dist/hoofd.js 2.3 kB +97 B (4%)
dist/hoofd.modern.js 2.27 kB +105 B (4%)
dist/hoofd.module.js 2.32 kB +97 B (4%)
dist/hoofd.umd.js 2.35 kB +93 B (3%)

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 689e0b6 into main Apr 28, 2023
3 checks passed
@JoviDeCroock JoviDeCroock deleted the improve-link-implementaiton branch April 28, 2023 07:18
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useLink does not work in strict mode; useTitle does work ok
1 participant