fix: subscription closed does not comply with proposal

[naporin0624]

Thank you for creating a great lightweight library.

I have fixed the difference between proposal-observable and the closed type in subscription.

The following are subscription types for proposal-observable.

interface Subscription {

    // Cancels the subscription
    unsubscribe() : void;

    // A boolean value indicating whether the subscription is closed
    get closed() : Boolean;
}

Current wonka subscription type.

interface ObservableSubscription {
  /** A boolean flag indicating whether the subscription is closed.
   * @remarks
   * When `true`, the subscription will not issue new values to the {@link ObservableObserver} and
   * has terminated. No new values are expected.
   *
   * @readonly
   */
  closed?: boolean;
  /** Cancels the subscription.
   * @remarks
   * This cancels the ongoing subscription and the {@link ObservableObserver}'s callbacks will
   * subsequently not be called at all. The subscription will be terminated and become inactive.
   */
  unsubscribe(): void;
}

Confirmed

• pnpm build passes
• pnpm check passes
• pnpm lint passes
• pnpn test passes

[kitten]

Nice catch!
I think I can see how I made this mistake. I think I wrote it as optional because of ObservableLike for fromObservable to make that type more flexible 🤔

Would you mind updating the return type here:

wonka/src/observable.ts

Line 79 in 990c8da

subscribe(observer: ObservableObserver<T>): ObservableSubscription;

To something like { unsubscribe(): void } please?
I think that'd help out a lot to keep fromObservable flexible while making toObservable more strict ✌️

[naporin0624]

ok! It took me a while, but I understand what you're saying and I'll fix it right away!

[kitten]

Thanks again! 🙌